Bring back vector render mode for vector tile layers #10309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note that hover selection performance in the updated https://454-4974939-gh.circle-artifacts.com/0/examples/vector-tile-selection.html example will be significantly improved when #10301 is merged. |
ahocevar
force-pushed
the
vectortile-rendermode-vector
branch
from
274e1ce to
cf6cd09
Compare
Member
Author
|
Thanks for any review. |
fredj
reviewed
Nov 29, 2019
fredj
approved these changes
Nov 29, 2019
ahocevar
force-pushed
the
vectortile-rendermode-vector
branch
from
d1f4e3f to
f0a32e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector render mode for vector tiles (i.e. no images for the render tiles are generated) was removed before v6. This pull request brings it back, because it is useful for creating highlight/selection layers for vector tile layers. I updated the vector-tile-selection example to show that.