Avoid naming required checks with a changing version #12248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI Jobs (workflow actions, whatever) are named with a combination of the os and Node version. This would be useful if we wanted to ensure that our tests pass on a matrix of os and Node version. However, we only test on a single os and Node version. When we update the version of Node where we want to run tests (e.g. #12247), we also have to change the name of all the required checks for branch protection. If this project were primarily used on Node, this could make sense. For this project, it ends up being a hassle because all outstanding pull requests need to be rebased.
If we want to require that all pull requests are updated before being merged, we can configure that. But we don't require that currently.