Add ol.structs.RBush#isEmpty

[twpayne]

No description provided.

[twpayne]

Trivial enough to merge immediately.

[ahocevar]

Trivial enough to merge immediately.

😕

[twpayne]

Sorry, I don't understand your response @ahocevar. Could you give more detail in words?

[bartvde]

See the guidelines here: "Any changes to master, aside from improvements to tests and documentation, shall first be submitted for review as a github pull request."

http://trac.osgeo.org/openlayers/wiki/HowToContribute

[bartvde]

I must admit that I thought examples were also not requiring review (which is why I merged an example a couple of days ago actually without review), but apparently only tests and documentation are exempted from review.

[ahocevar]

@twpayne While I agree that this specific pull request was trivial, I still think that a good community citizen should not judge their own pull requests trivial or non trivial. If you do this, others might start doing it too, and it is my educated guess that you'll be one of the first to dislike such behaviour.

[twpayne]

See the guidelines here: "Any changes to master, aside from improvements to tests and documentation, shall first be submitted for review as a github pull request."

@bartvde, perhaps you can explain this to @ahocevar (refs #1280 #1246 #1095 ...).

[bartvde]

this is not really fair @twpayne

#1246 was fixing an immediate issue with Travis
#1095 is improvement to tests so exempted

#1280 is an example only, no code, strictly speaking needs review though but maybe we should change this

[ahocevar]

I also was under the impression that examples can be merged without review, so I apologize for #1280. @bartvde I think it cannot hurt to demand reviews for examples also, so I'll stop merging example code without review from now on.

[bartvde]

@ahocevar agreed on the examples. I'll also remember from now on not to merge an example without review.

Let's all just stick to the rules and not make exceptions, that's the easiest.