New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to bootstrap 5.2 #13996
Update to bootstrap 5.2 #13996
Conversation
📦 Preview the website for this branch here: https://deploy-preview-13996--ol-site.netlify.app/. |
Yes it was very necessary ! @MoonE good job !
|
@MoonE |
Thanks, @jipexu, I'm aware of that. I'll provide a new PR to remove jquery once this is merged. |
ah ok good ! update bs is always a lot of work ... |
This is looking really good. Thanks for all your work on the upgrade, @MoonE! |
2b5a55c
to
8d284e5
Compare
@jipexu Sorry, I may have misundertstood. Even with jQueryand bootstrap 5 these tooltips no longer worked, though there are the normal browser tooltips from the I udpated the examples to work again with bootstrap 5, hopefully everything is working now. |
@MoonE yes i see your change are ok good job ! this example work again in deploy https://deploy-preview-13996--ol-site.netlify.app/en/latest/examples/kml-timezones.html |
@MoonE |
@jipexu Honestly it doesn't really matter, either works without problems. I simply prefer it to be consistent. |
site/src/doc/quickstart.md
Outdated
@@ -41,6 +41,10 @@ Open the `index.html` file in a text editor. It should look something like this | |||
<head> | |||
<meta charset="UTF-8" /> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
<title>Quick Start</title> | |||
<style> | |||
#map { height: 400px; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflicts with the rule in the style.css. Not important to change, but I also don’t think it needs to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct, I didn't notice the css imported from the js file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the huge effort, @MoonE!
I'll provide a separate pull request to remove jquery for some parts shortly.jQuery is removed except a few pages.