Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing goog.events.EventType.DBLCLICK argument to unlisten #160

Merged
merged 4 commits into from Jan 28, 2013
Merged

Add missing goog.events.EventType.DBLCLICK argument to unlisten #160

merged 4 commits into from Jan 28, 2013

Conversation

fredj
Copy link
Member

@fredj fredj commented Jan 28, 2013

unlisten arguments should be the same as listen

@elemoine
Copy link
Member

Looks good.

@twpayne
Copy link
Contributor

twpayne commented Jan 28, 2013

Looks good, but shouldn't this event listening be better managed with goog.events.unlistenByKey?

@fredj
Copy link
Member Author

fredj commented Jan 28, 2013

Good point, will change

@fredj
Copy link
Member Author

fredj commented Jan 28, 2013

I've added two other commits to use goog.events.unlistenByKey for this.handleDown_ and removed a duplicated event listener removal

fredj added a commit that referenced this pull request Jan 28, 2013
@fredj
Merge pull request #160 from fredj/dblclick-unlisten
eb103d3 
Remove event listener cleanups
@fredj fredj merged commit eb103d3 into openlayers:master Jan 28, 2013
@fredj fredj deleted the dblclick-unlisten branch January 28, 2013 12:19
@fvanderbiest fvanderbiest mentioned this pull request Nov 5, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r3.0.0-alpha.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredj @elemoine @twpayne