Add missing goog.events.EventType.DBLCLICK argument to unlisten #160

Merged
merged 4 commits into from Jan 28, 2013

Conversation

Projects
None yet
3 participants
Owner

fredj commented Jan 28, 2013

unlisten arguments should be the same as listen

Owner

elemoine commented Jan 28, 2013

Looks good.

Contributor

twpayne commented Jan 28, 2013

Looks good, but shouldn't this event listening be better managed with goog.events.unlistenByKey?

Owner

fredj commented Jan 28, 2013

Good point, will change

Owner

fredj commented Jan 28, 2013

I've added two other commits to use goog.events.unlistenByKey for this.handleDown_ and removed a duplicated event listener removal

fredj added a commit that referenced this pull request Jan 28, 2013

@fredj fredj merged commit eb103d3 into openlayers:master Jan 28, 2013

1 check passed

default The Travis build passed
Details

@fredj fredj deleted the fredj:dblclick-unlisten branch Jan 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment