Add styles for .ol-touch .ol-zoomslider #1614

Merged
merged 4 commits into from Mar 24, 2014

Projects

None yet

5 participants

@austinhyde
Contributor

Scales the ZoomSlider to match the Zoom in/out controls in a .ol-touch map

Owner

Does the zoom slider actually work on touch devices? I thought it did not.

Contributor

Heh, I didn't try. What I do know is that IE 10+ appears to be reporting itself as being touch compatible, regardless of the device it is running on, so OL adds the ol-touch class to the map container. This means the zoom in/out buttons are enlarged, but the zoom slider is left at the standard size, which looks a little off. These style changes just fix that case.

Owner
bartvde commented Jan 29, 2014

see also #991

Contributor

see also #991

This is exactly what this PR fixes. Here's a screenshot from IE 11 with the updated styles:

zoomslider example

Owner
bartvde commented Jan 29, 2014

Right, that's why I put in the reference. Nice work! And thanks.

Owner
bartvde commented Feb 13, 2014

Are there any objections to merging this one?

Contributor
twpayne commented Feb 13, 2014

Not from me, although I am not able to test it at the moment.

Owner
bartvde commented Feb 13, 2014

I'll test it out before merging

Owner
bartvde commented Feb 13, 2014

@austinhyde can you please rebase this one?

Contributor

Done, have at it!

Contributor

This is now relatively broken since the changes to zoom controls. We'll fix and update.

Contributor

Styling should be all up to date now and ready to merge. Everything looks good in all browsers, even IE8!

Contributor
twpayne commented Mar 23, 2014

Any reasons for not merging this? Can anyone test?

Member

I'll check this.

Member

This is looking fine in IE11 on Win 8.1, FF 28 and Chrome 33 (both on Linux).

On IE 9 (Win 7) this sort-of works, but that browser would definitely need more love with regard to CSS (see below). This is most probably not introduced here, so nothing is stopping this from being merged.

zoomslider-ie9

Thanks @austinhyde & @simxpgh.

@marcjansen marcjansen merged commit 84463f5 into openlayers:master Mar 24, 2014

1 check passed

default The Travis CI build passed
Details
@austinhyde austinhyde deleted the Intermedix:ol-touch-zoomslider branch Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment