Rotate around arbitrary coordinate #1773

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
3 participants
@elemoine
Member

elemoine commented Feb 27, 2014

This PR makes it possible to rotate the view around any geographical position. This is useful for a navigation system where the current position (obtained through the geolocation API) is not displayed on the center of the map.

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Feb 27, 2014

Member

The build fails on all.combined.js. Checking now...

Member

elemoine commented Feb 27, 2014

The build fails on all.combined.js. Checking now...

@twpayne

This comment has been minimized.

Show comment
Hide comment
@twpayne

twpayne Feb 27, 2014

Contributor

The code looks good, but in the animation example the "Rotate around Rome" button only works once. Maybe it should rotate by pi/4 each time it's clicked?

Contributor

twpayne commented Feb 27, 2014

The code looks good, but in the animation example the "Rotate around Rome" button only works once. Maybe it should rotate by pi/4 each time it's clicked?

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Feb 27, 2014

Member

Build now passes.

Thanks @twpayne for the suggestion. I'll modify the example.

Member

elemoine commented Feb 27, 2014

Build now passes.

Thanks @twpayne for the suggestion. I'll modify the example.

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Feb 27, 2014

Member

I've fixed the example. The example is available here: http://erilem.net/ol3/rotation-anchor/examples/animation.html.

Member

elemoine commented Feb 27, 2014

I've fixed the example. The example is available here: http://erilem.net/ol3/rotation-anchor/examples/animation.html.

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Feb 27, 2014

Member

Leaving this open for now. @pgiraud is going to test that in a real application.

Member

elemoine commented Feb 27, 2014

Leaving this open for now. @pgiraud is going to test that in a real application.

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Feb 28, 2014

Member

Successfully tested by @pgiraud. And rebased onto the current master.

Member

elemoine commented Feb 28, 2014

Successfully tested by @pgiraud. And rebased onto the current master.

@twpayne

This comment has been minimized.

Show comment
Hide comment
@twpayne

twpayne Feb 28, 2014

Contributor

All looks good to me!

Contributor

twpayne commented Feb 28, 2014

All looks good to me!

@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj Mar 5, 2014

Member

+1 nice addition, thanks

Member

fredj commented Mar 5, 2014

+1 nice addition, thanks

@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj Mar 12, 2014

Member

Is it ready to be merged?

Member

fredj commented Mar 12, 2014

Is it ready to be merged?

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Mar 12, 2014

Member

I wanted to verify with @pgiraud that the patch works for him. I'll check with him before merging.

Member

elemoine commented Mar 12, 2014

I wanted to verify with @pgiraud that the patch works for him. I'll check with him before merging.

@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj Apr 10, 2014

Member
@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj Apr 10, 2014

Member

@elemoine , @pgiraud : I'm going to need this for a project soon; any objections to merge?

Member

fredj commented Apr 10, 2014

@elemoine , @pgiraud : I'm going to need this for a project soon; any objections to merge?

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Apr 10, 2014

Member

No, if it works for you then great.

Member

elemoine commented Apr 10, 2014

No, if it works for you then great.

@fredj

This comment has been minimized.

Show comment
Hide comment
@fredj

fredj Apr 10, 2014

Member

Thanks, see #1975

Member

fredj commented Apr 10, 2014

Thanks, see #1975

@fredj fredj closed this Apr 10, 2014

@elemoine elemoine deleted the elemoine:rotation-anchor branch Apr 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment