Skip to content

Conversation

@fredj
Copy link
Member

@fredj fredj commented Dec 9, 2014

No description provided.

@bartvde
Copy link
Member

bartvde commented Dec 9, 2014

@fredj I'm starting to wonder how you found all these missing options ;-) any way we can add this to the automated check target?

@elemoine
Copy link
Member

elemoine commented Dec 9, 2014

any way we can add this to the automated check target?

No need. We have @fredj for that :-)

@bartvde
Copy link
Member

bartvde commented Dec 9, 2014

LOL

@elemoine
Copy link
Member

elemoine commented Dec 9, 2014

Always use ./build.py fredj before pushing.

@bartvde
Copy link
Member

bartvde commented Dec 9, 2014

LGTM please merge

@fredj
Copy link
Member Author

fredj commented Dec 9, 2014

I've found this while working on #3029; the closure-compiler has a new (and not ready to use) option (https://github.com/openlayers/closure-util/blob/master/compiler-options.txt#L184) that detects this kind of errors.

@bartvde
Copy link
Member

bartvde commented Dec 9, 2014

ah interesting, thanks for the pointer @fredj

@fredj
Copy link
Member Author

fredj commented Dec 9, 2014

That's true that we should be able to detect this kind of errors ...

fredj added a commit that referenced this pull request Dec 9, 2014
Add missing maxZoom property in olx.view.FitGeometryOptions
@fredj fredj merged commit 0052116 into openlayers:master Dec 9, 2014
@fredj fredj deleted the FitGeometryOptions branch December 9, 2014 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants