Add ol.Object.unset() method #3410
Merged
+30
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ol/object.js
Outdated
Member
There was a problem hiding this comment.
I don't think we use the term "own observable property" elsewhere. And I don't really understand it. So I'd just say "Properties can be deleted by using the unset method. E.g. object.unset('foo')."
Member
Author
There was a problem hiding this comment.
The description of the class writes about `Classes that inherit from this
have pre-defined properties, to which you can add your own.`
You are right `own observable properties` is a bit too much.
What about using `own properties` to differenciate from the `pre-defined` properties?
Member
|
I just added a comment regarding the vocabulary used in the docs. Otherwise looks good to me. |
src/ol/object.js
Outdated
Member
There was a problem hiding this comment.
Add a description.
* @param {string} key The property key.
gberaudo
force-pushed
the
ol_object_unset
branch
from
fb1afa4 to
267e2e6
Compare
Allow deleting a property.
gberaudo
force-pushed
the
ol_object_unset
branch
from
267e2e6 to
6e7221c
Compare
Member
Author
|
The PR was updated based on your comments. Thank you for the review @elemoine. |
Member
|
Thanks. Will merge when the Travis build is finished. |
elemoine
pushed a commit
that referenced
this pull request
Mar 30, 2015
Add ol.Object.unset() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows deletion of an object property.
Closes: #3404