Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unmanaged vector layers behave more like ol.FeatureOverlay #3820

Merged

Conversation

ahocevar
Copy link
Member

  • Skipped features need to be hit-detected on unmanaged layers.
  • updateWhileAnimating and updateWhileInteracting are recommended to achieve the same instant visual feedback that ol.FeatureOverlay had.

Fixes #3819.

@ahocevar ahocevar force-pushed the vectorlayer-like-featureoverlay branch from bf1b99d to ddba6fa Compare June 18, 2015 21:44
@probins
Copy link
Contributor

probins commented Jun 18, 2015

if these are new options, they need to be added to olx.js don't they?

@ahocevar
Copy link
Member Author

These options are not new. They are in 0LX.JS already.

@probins
Copy link
Contributor

probins commented Jun 19, 2015

on the layer. Your example in upgrade-notes has them on the source

* Skipped features need to be hit-detected on unmanaged layers.
* updateWhileAnimating and updateWhileInteracting are recommended to
  achieve the same instant visual feedback that ol.FeatureOverlay had.
@ahocevar ahocevar force-pushed the vectorlayer-like-featureoverlay branch from ddba6fa to f645a9e Compare June 19, 2015 11:06
@ahocevar
Copy link
Member Author

Thanks @probins, good catch again. I updated the pull request.

@elemoine
Copy link
Member

Please merge.

ahocevar added a commit that referenced this pull request Jun 19, 2015
Make unmanaged vector layers behave more like ol.FeatureOverlay
@ahocevar ahocevar merged commit 0af5642 into openlayers:master Jun 19, 2015
@ahocevar ahocevar deleted the vectorlayer-like-featureoverlay branch June 19, 2015 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants