New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unmanaged vector layers behave more like ol.FeatureOverlay #3820

Merged
merged 1 commit into from Jun 19, 2015

Conversation

Projects
None yet
3 participants
@ahocevar
Member

ahocevar commented Jun 18, 2015

  • Skipped features need to be hit-detected on unmanaged layers.
  • updateWhileAnimating and updateWhileInteracting are recommended to achieve the same instant visual feedback that ol.FeatureOverlay had.

Fixes #3819.

@probins

This comment has been minimized.

Show comment
Hide comment
@probins

probins Jun 18, 2015

Contributor

if these are new options, they need to be added to olx.js don't they?

Contributor

probins commented Jun 18, 2015

if these are new options, they need to be added to olx.js don't they?

@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Jun 18, 2015

Member

These options are not new. They are in 0LX.JS already.

Member

ahocevar commented Jun 18, 2015

These options are not new. They are in 0LX.JS already.

@probins

This comment has been minimized.

Show comment
Hide comment
@probins

probins Jun 19, 2015

Contributor

on the layer. Your example in upgrade-notes has them on the source

Contributor

probins commented Jun 19, 2015

on the layer. Your example in upgrade-notes has them on the source

Make unmanaged vector layers behave more like ol.FeatureOverlay
* Skipped features need to be hit-detected on unmanaged layers.
* updateWhileAnimating and updateWhileInteracting are recommended to
  achieve the same instant visual feedback that ol.FeatureOverlay had.
@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Jun 19, 2015

Member

Thanks @probins, good catch again. I updated the pull request.

Member

ahocevar commented Jun 19, 2015

Thanks @probins, good catch again. I updated the pull request.

@elemoine

This comment has been minimized.

Show comment
Hide comment
@elemoine

elemoine Jun 19, 2015

Member

Please merge.

Member

elemoine commented Jun 19, 2015

Please merge.

ahocevar added a commit that referenced this pull request Jun 19, 2015

Merge pull request #3820 from ahocevar/vectorlayer-like-featureoverlay
Make unmanaged vector layers behave more like ol.FeatureOverlay

@ahocevar ahocevar merged commit 0af5642 into openlayers:master Jun 19, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0%) to 72.53%
Details

@ahocevar ahocevar deleted the ahocevar:vectorlayer-like-featureoverlay branch Jun 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment