Ignore layer filter for unmanaged layers #3883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
foreachfeatureatpixel-unmanaged-always
branch
from
3d4027e to
6bef2ce
Compare
To make unmanaged vector layers work like the removed ol.FeatureOverlay, the layer filter for ol.Map#forEachFeatureAtPixel needs to ignore unmanaged layers.
ahocevar
force-pushed
the
foreachfeatureatpixel-unmanaged-always
branch
from
6bef2ce to
26e146b
Compare
|
LGTM |
ahocevar
added a commit
that referenced
this pull request
Jul 8, 2015
…d-always Ignore layer filter for unmanaged layers
|
I wonder if this fixes #3885 as well. |
This was referenced Sep 21, 2015
| @@ -167,8 +167,9 @@ ol.renderer.Map.prototype.forEachFeatureAtCoordinate = | |||
| for (i = numLayers - 1; i >= 0; --i) { | |||
| var layerState = layerStates[i]; | |||
| var layer = layerState.layer; | |||
| if (ol.layer.Layer.visibleAtResolution(layerState, viewResolution) && | |||
| layerFilter.call(thisArg2, layer)) { | |||
| if (!layerState.managed || | |||
There was a problem hiding this comment.
shouldn't this be if (layerState.managed && ?
There was a problem hiding this comment.
ahocevar
pushed a commit
to ahocevar/openlayers
that referenced
this pull request
Nov 22, 2015
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
ahocevar
pushed a commit
to ahocevar/openlayers
that referenced
this pull request
Nov 22, 2015
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
ahocevar
pushed a commit
to ahocevar/openlayers
that referenced
this pull request
Nov 22, 2015
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
ahocevar
pushed a commit
to ahocevar/openlayers
that referenced
this pull request
Nov 30, 2015
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make unmanaged vector layers work like the removed ol.FeatureOverlay, the layer filter for ol.Map#forEachFeatureAtPixel needs to ignore unmanaged layers.
Fixes #3878.