Add color option to ol.style.Icon #4457
Conversation
|
@ahocevar, I ended up multiplying pixel values instead of replacing white with the colour because the latter left undesired artifacts in the majority of cases (e.g. anything with antialiasing) |
alexbrault
force-pushed
the
colour-icon
branch
from
12e2a14 to
afe11b3
Compare
|
Thanks for this pull request @alexbrault. Great enhancement! I'll review it within the next few days. |
src/ol/style/iconstyle.js
Outdated
There was a problem hiding this comment.
Applying the color will only work if the image is not tainted.
It should be moved after determineTainting().
alexbrault
force-pushed
the
colour-icon
branch
4 times, most recently
from
06a5230 to
28633e4
Compare
externs/olx.js
Outdated
There was a problem hiding this comment.
Would be nice to also accept a string here.
There was a problem hiding this comment.
I forget what my reasoning for omitting this was, but yes, it should
alexbrault
force-pushed
the
colour-icon
branch
from
28633e4 to
c80ff96
Compare
alexbrault
force-pushed
the
colour-icon
branch
from
c80ff96 to
3f16b34
Compare
|
This looks great @alexbrault. It looks like we do not have a CLA on file from you yet. Can you please submit one so we can merge this? |
Thanks @alexbrault for openlayers/openlayers#4457 and any future contributions you can make.
Add color option to ol.style.Icon
There was a problem hiding this comment.
I think it would be nicer to have a dedicated example that shows what this option should be used for. We have a bad tendency to continue modifying examples that started out simple until they become overly complex (or just ugly). And I think this particular example looked nicer before the color option was added (same goes for opacity).
There was a problem hiding this comment.
Good point. I'll submit a PR to fork the example
5 participants
This PR adds a color option to tint an ol.style.Icon.
See https://groups.google.com/forum/#!topic/ol3-dev/vPK4ygQHaqo