Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore layer filter for unmanaged layers #4472

Merged
merged 2 commits into from Dec 1, 2015

Conversation

@ahocevar
Copy link
Member

@ahocevar ahocevar commented Nov 22, 2015

PR #3883 made forEachFeatureAtPixel ignore unmanaged layers. This commit reverts that change.

This is an updated version of #4143.

Now that we return null as layer in the ol.Map#forEachFeartureAtPixel callback, we can pass unmanaged layers to the layer filter again, without the side effects that I feared when I reviewed #4143.

Fixes #4471.
Fixes #2940.

@ahocevar
Copy link
Member Author

@ahocevar ahocevar commented Nov 22, 2015

Sorry @tschaub, too many numbers again. But I feel like the select interaction and unmanaged layers mess is finally untangled now - also thanks to @elemoine.

@ahocevar ahocevar force-pushed the ahocevar:layer-filter branch 2 times, most recently from a25b175 to 6c975f8 Nov 22, 2015
elemoine and others added 2 commits Sep 21, 2015
PR #3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
@ahocevar ahocevar force-pushed the ahocevar:layer-filter branch from 91124dd to 40fec9c Nov 30, 2015
@pgiraud
Copy link
Member

@pgiraud pgiraud commented Dec 1, 2015

+1

ahocevar added a commit that referenced this pull request Dec 1, 2015
Do not ignore layer filter for unmanaged layers
@ahocevar ahocevar merged commit 2215f49 into openlayers:master Dec 1, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 74.892%
Details
@ahocevar ahocevar deleted the ahocevar:layer-filter branch Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants