Do not ignore layer filter for unmanaged layers #4472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
force-pushed
the
layer-filter
branch
2 times, most recently
from
a25b175 to
6c975f8
Compare
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
ahocevar
force-pushed
the
layer-filter
branch
from
91124dd to
40fec9c
Compare
|
+1 |
ahocevar
added a commit
that referenced
this pull request
Dec 1, 2015
Do not ignore layer filter for unmanaged layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3883 made
forEachFeatureAtPixelignore unmanaged layers. This commit reverts that change.This is an updated version of #4143.
Now that we return
nullas layer in theol.Map#forEachFeartureAtPixelcallback, we can pass unmanaged layers to the layer filter again, without the side effects that I feared when I reviewed #4143.Fixes #4471.
Fixes #2940.