Skip to content

Do not ignore layer filter for unmanaged layers #4472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2015

Conversation

ahocevar
Copy link
Member

PR #3883 made forEachFeatureAtPixel ignore unmanaged layers. This commit reverts that change.

This is an updated version of #4143.

Now that we return null as layer in the ol.Map#forEachFeartureAtPixel callback, we can pass unmanaged layers to the layer filter again, without the side effects that I feared when I reviewed #4143.

Fixes #4471.
Fixes #2940.

@ahocevar
Copy link
Member Author

Sorry @tschaub, too many numbers again. But I feel like the select interaction and unmanaged layers mess is finally untangled now - also thanks to @elemoine.

elemoine and others added 2 commits November 30, 2015 17:53
PR openlayers#3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
@pgiraud
Copy link
Member

pgiraud commented Dec 1, 2015

+1

ahocevar added a commit that referenced this pull request Dec 1, 2015
Do not ignore layer filter for unmanaged layers
@ahocevar ahocevar merged commit 2215f49 into openlayers:master Dec 1, 2015
@ahocevar ahocevar deleted the layer-filter branch December 1, 2015 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants