Do not ignore layer filter for unmanaged layers #4472

Merged
merged 2 commits into from Dec 1, 2015

Conversation

Projects
None yet
3 participants
@ahocevar
Member

ahocevar commented Nov 22, 2015

PR #3883 made forEachFeatureAtPixel ignore unmanaged layers. This commit reverts that change.

This is an updated version of #4143.

Now that we return null as layer in the ol.Map#forEachFeartureAtPixel callback, we can pass unmanaged layers to the layer filter again, without the side effects that I feared when I reviewed #4143.

Fixes #4471.
Fixes #2940.

@ahocevar

This comment has been minimized.

Show comment
Hide comment
@ahocevar

ahocevar Nov 22, 2015

Member

Sorry @tschaub, too many numbers again. But I feel like the select interaction and unmanaged layers mess is finally untangled now - also thanks to @elemoine.

Member

ahocevar commented Nov 22, 2015

Sorry @tschaub, too many numbers again. But I feel like the select interaction and unmanaged layers mess is finally untangled now - also thanks to @elemoine.

elemoine and others added some commits Sep 21, 2015

Do not ignore layer filter for unmanaged layers
PR #3883 made `forEachFeatureAtPixel` ignore unmanaged layers. This commit reverts that change.
@pgiraud

This comment has been minimized.

Show comment
Hide comment
@pgiraud

pgiraud Dec 1, 2015

Member

+1

Member

pgiraud commented Dec 1, 2015

+1

ahocevar added a commit that referenced this pull request Dec 1, 2015

Merge pull request #4472 from ahocevar/layer-filter
Do not ignore layer filter for unmanaged layers

@ahocevar ahocevar merged commit 2215f49 into openlayers:master Dec 1, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 74.892%
Details

@ahocevar ahocevar deleted the ahocevar:layer-filter branch Dec 1, 2015

@pgiraud pgiraud referenced this pull request in Geoportail-Luxembourg/geoportailv3 Dec 1, 2015

Closed

measure tools don't work any more #951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment