Fix up failing tests in Internet Explorer #4475
Conversation
|
Are you also testing the examples manually to see if there is something in the library that needs to be fixed? Do you want me to help? I think we should fully support IE10+. |
|
Not as yet @ahocevar but that might make sense to do as well after I finish up the unit tests. |
|
do you remember what was the case with |
|
on second runs strange things happen, like pixelworks error for ol.source.TileJSON, maybe due to test cleanup?
|
|
if I take out the |
|
|
|
I'm looking into the raster issue now. |
There was a problem hiding this comment.
Now last is not a good name any more. feature?
There was a problem hiding this comment.
It's still the last feature, I just made the file smaller because it was very slow parsing in IE
There was a problem hiding this comment.
Ah ok. You didn't push the data change.
There was a problem hiding this comment.
I did, it's here: test/spec/ol/format/esrijson/ksfields.json just on top of this (I pretty printed it in the process)
There was a problem hiding this comment.
Oh sorry, you did. It's just collapsed in the diff.
|
The example template has a minor issue in IE11, the select combo option only shows up on hover, not by default. Seems to be caused by color: inherit from the bootstrap css.
|
|
Also the logo is stretched in IE, and I think we saw this before?
|
|
The raster source uses the |
|
All tests now pass in IE9, IE10 and IE11 |
|
Some commit messages do not comply with the rules, you may want to split them into title and description. Looks good otherwise. |
For 2 test cases, the thresholds were also too low for Chrome on OSX.
The threshold needed to be even higher for Safari on OSX.
Fix up failing tests in Internet Explorer
3 participants
A lot of test cases currently fail in Internet Explorer.
This is a WIP on fixing them. Will update the description once I'm done.