Skip to content

Conversation

@fredj
Copy link
Member

@fredj fredj commented Nov 30, 2015

No description provided.

@fredj
Copy link
Member Author

fredj commented Dec 1, 2015

It was the last goog.object.getKeys in ol3, thanks for any review

@marcjansen
Copy link
Member

This looks good, @fredj. Do you think we must mention that it'll never be null from now on?

Please merge, with or without a note.

Thanks.

@fredj
Copy link
Member Author

fredj commented Dec 2, 2015

pointerMap was already never null but the annotation was not precise.

@fredj
Copy link
Member Author

fredj commented Dec 2, 2015

Thanks for the review Marc

fredj added a commit that referenced this pull request Dec 2, 2015
@fredj fredj merged commit 652638e into openlayers:master Dec 2, 2015
@fredj fredj deleted the rm_goog_object_getKeys branch December 2, 2015 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants