Unlisten before calling listener and bind to target by default #4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
changed the title
examples/vector-layer.js
Outdated
| this.getSource().forEachFeature(function(feature) { | ||
| feature.setId(id++); | ||
| }); | ||
| }); |
Member
There was a problem hiding this comment.
Was this meant to be a test instead? :)
Member
Author
There was a problem hiding this comment.
Yes, I'll be pushing an update shortly.
ahocevar
force-pushed
the
unlisten-earlier-and-bind-to-target
branch
from
bc844fb to
77ffe99
Compare
Member
Author
|
Tests added. |
ahocevar
force-pushed
the
unlisten-earlier-and-bind-to-target
branch
from
77ffe99 to
00a0f14
Compare
Member
|
Nice fix @ahocevar. Please merge. |
ahocevar
added a commit
that referenced
this pull request
Feb 25, 2016
…arget Unlisten before calling listener and bind to target by default
Member
Author
|
Thanks for the quick review @tschaub. |
ahocevar
added a commit
that referenced
this pull request
Mar 1, 2016
…arget Unlisten before calling listener and bind to target by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem reported in #4919 is a regression caused by the
goog.events.*removal. Listeners were always called synchronously, but the difference with the new implementation is that aoncelistener is unregistered after calling the listener, whereas it was unregistered before previously. The second problem is that whenopt_thisis not provided, we no longer bind to the event target by default.Fixes #4919.