Add an updateSize method #532

Merged
merged 1 commit into from Apr 10, 2013

Conversation

Projects
None yet
3 participants
Owner

tschaub commented Apr 10, 2013

We need a non-private/protected method to call when the map viewport size changes.

This should also be made part of the API, so third-party code can change it when something else is responsible for a viewport size change that we can't detect.

The (upcoming) full-screen control should also likely call updateSize to handle the case where the window size doesn't change when entering full screen mode. In Chrome, you can start in presentation mode and click the control to go in full-screen mode. This might be considered a degenerate case. But the point still stands that 3rd party code will have to tell the map to recalculate its viewport size.

@tschaub tschaub Add an updateSize method
We need a non-private/protected method to call when the map viewport size changes.
b499f71
Contributor

twpayne commented Apr 10, 2013

+1

Owner

elemoine commented Apr 10, 2013

+1

tschaub merged commit d71da50 into openlayers:master Apr 10, 2013

1 check passed

default The Travis build passed
Details

tschaub deleted the tschaub:update-size branch Apr 10, 2013

fredj referenced this pull request Apr 30, 2013

Merged

Export ol.Map.updateSize #672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment