Keep the other dim from the original segment when modifying vertex #6075

Merged
merged 1 commit into from Dec 7, 2016

Projects

None yet

2 participants

@tchandelle
Contributor

Previously, when modifying a 3d geometry, the third dimension was lost when you move a vertex, replaced by zero. This commit fixes it.

However, when adding a new vertex in a segment, the third dimension will still be zero. Should it be the average between the previous and next vertex?

@tchandelle tchandelle Keep the other dim from the original segment when modifying vertex
5d61218
@marcjansen
Member

This looks very solid. I hope to have a deeper look the next days.

@tchandelle
Contributor

Is there a chance to have this in next version, we would really appreciate this correction.
@marcjansen ?

@marcjansen

Sorry, I forgot about that one. Still looks good, thanks.

@marcjansen marcjansen merged commit f795019 into openlayers:master Dec 7, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 86.498%
Details
@tchandelle tchandelle deleted the tchandelle:modify_stride branch Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment