kml rendering in advanced compilation mode #638

Merged
merged 2 commits into from Apr 23, 2013

Conversation

Projects
None yet
2 participants
@ahocevar
Member

ahocevar commented Apr 22, 2013

In advanced compilation mode, the KML example looks wrong:
http://ol3js.org/en/r3.0.0-alpha.1/examples/kml.html
vs:
http://ol3js.org/en/r3.0.0-alpha.1/examples/kml.html?mode=raw

An extern is probably missing somewhere.

@bartvde

This comment has been minimized.

Show comment Hide comment
@bartvde

bartvde Apr 22, 2013

Member

as @ahocevar pointed out also the sun icon is missing for the point feature even in RAW mode.

Member

bartvde commented Apr 22, 2013

as @ahocevar pointed out also the sun icon is missing for the point feature even in RAW mode.

@ahocevar

This comment has been minimized.

Show comment Hide comment
@ahocevar

ahocevar Apr 22, 2013

Member

This is because the KML parser options are not exported. I'm attaching a pull request right now.

Member

ahocevar commented Apr 22, 2013

This is because the KML parser options are not exported. I'm attaching a pull request right now.

Exporting KML parser options
This is necessary because application developers need to be able
to configure the KML parser.
@ahocevar

This comment has been minimized.

Show comment Hide comment
@ahocevar

ahocevar Apr 22, 2013

Member

The missing sun icon issue will be fixed with #641, and the pull request attached here fixes the issue with the strange looking lines (which comes from the elevation being interpreted as x or y coordinate).

Member

ahocevar commented Apr 22, 2013

The missing sun icon issue will be fixed with #641, and the pull request attached here fixes the issue with the strange looking lines (which comes from the elevation being interpreted as x or y coordinate).

Making the linter happy
... although jsdoc files are none of the linter's business.
@bartvde

This comment has been minimized.

Show comment Hide comment
@bartvde

bartvde Apr 23, 2013

Member

verified with the host-examples build target - thanks for tracking this down @ahocevar please merge

Member

bartvde commented Apr 23, 2013

verified with the host-examples build target - thanks for tracking this down @ahocevar please merge

ahocevar added a commit that referenced this pull request Apr 23, 2013

Merge pull request #638 from ahocevar/kml-options
KML rendering in advanced compilation mode. r=@bartvde

@ahocevar ahocevar merged commit f681a99 into openlayers:master Apr 23, 2013

1 check passed

default The Travis build passed
Details

@ahocevar ahocevar deleted the ahocevar:kml-options branch Apr 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment