Add Assertion.prototype.xmleql #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Thanks for this work @bartvde. Are the error messages sufficient to figure out where the failure comes from? I'm in favor of merging regardless, but curious what the output on failure looks like. |
|
Please merge. |
This is based on the xml_eq function we had in the OL2 test framework but adapted to expect.js.
|
@tschaub I'll merge this first and then look into your question, and possibly come up with a new PR. Thanks for pointing this out. |
Thanks Bart. That's what we said during last week's dev meeting. |
|
there were some serious flaws here on further inspection (did not really test anything since it was not using documentElement), so I'll definitely update with a new PR |
|
see #689 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the xml_eq function we had in the OL2 test framework but
adapted to expect.js.