Testing clean-ups #676

Merged
merged 5 commits into from May 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

twpayne commented Apr 30, 2013

Various clean-ups to the testing framework to make your life easier:

  • Display errors in Chrome's console so you can click on the stack trace to jump to the failing tes (see #391)
  • Extend expect.js's eql to consider NaNs equivalent
  • Use eql instead of equalArray

@twpayne twpayne added a commit that referenced this pull request May 1, 2013

@twpayne twpayne Merge pull request #676 from twpayne/testing-clean-ups
Testing clean-ups
70fc687

@twpayne twpayne merged commit 70fc687 into openlayers:master May 1, 2013

1 check passed

default The Travis build passed
Details

twpayne deleted the twpayne:testing-clean-ups branch May 1, 2013

Owner

elemoine commented May 2, 2013

Looks good Tom. Just wondering why we introduced equalArray in the first place.

Contributor

twpayne commented May 2, 2013

I added equalArray in the first place because I hadn't found eql.

Owner

elemoine commented May 2, 2013

Ok. Thanks.

Owner

ahocevar commented on fcc079a May 8, 2013

Not good. This makes eql return true for all non-object types that return true for isNaN - e.g. for all strings.

Contributor

twpayne replied May 8, 2013

Oops. WIll fix.

Contributor

twpayne replied May 8, 2013

See #697.

@afabiani afabiani pushed a commit to geosolutions-it/openlayers that referenced this pull request May 22, 2017

@tschaub tschaub Merge pull request #676 from tschaub/osm-copyright
Updating attribution for OSM layer.
877d81c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment