Add method to set max cache size in ol.style.IconImageCache #7372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
approved these changes
Oct 19, 2017
Member
|
travis is stuck; @bobobobo can you try to push force you branch to restart it? |
Contributor
Author
|
@fredj Do you want me to rebase and force push? |
Member
What I usually do to push force is: |
bobobobo
force-pushed
the
iconimagecache-setmaxcachesize
branch
from
0287de3 to
f2cfe9d
Compare
bobobobo
force-pushed
the
iconimagecache-setmaxcachesize
branch
from
f2cfe9d to
343a408
Compare
ahocevar
reviewed
Nov 3, 2017
src/ol/style/iconimagecache.js
Outdated
| * Set cache max size. | ||
| * @param {number} maxCacheSize Cache max size. | ||
| */ | ||
| ol.style.IconImageCache.prototype.setMaxCacheSize = function(maxCacheSize) { |
Member
There was a problem hiding this comment.
What about naming this nicer (setSize) and adding an @api annotation and some more verbose documentation?
ahocevar
force-pushed
the
iconimagecache-setmaxcachesize
branch
from
f0028a0 to
8a9f32f
Compare
Member
|
I took the liberty to make the changes I suggested. |
ahocevar
approved these changes
Dec 1, 2017
mdastous-bentley
pushed a commit
to BentleySystems/openlayers
that referenced
this pull request
May 27, 2020
…xcachesize Add method to set max cache size in ol.style.IconImageCache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to set max cache size as requested in #7233