Named exports from ol/has #7764
Conversation
|
Hey Tim, looking into this now. Please see #7765 |
|
Thanks @marcjansen. I'm debugging the test failure with dashed lines. It looks like we shouldn't have any conflicts between this and #7765. I'll review that after fixing up the tests here. |
src/ol/has.js
Outdated
| return false; | ||
| } | ||
| })(); | ||
| export const CANVAS_LINE_DASH = false; |
There was a problem hiding this comment.
That is quite a change or not?
| }); | ||
|
|
||
| it('works in DOM_DELTA_LINE mode (wheel)', function(done) { | ||
| if (FIREFOX) { |
| it('works on Safari (wheel)', function(done) { | ||
| const origHasSafari = _ol_has_.SAFARI; | ||
| _ol_has_.SAFARI = true; | ||
| if (!FIREFOX) { |
There was a problem hiding this comment.
Isn't this too broad? Should this test for Safari explicitly?
There was a problem hiding this comment.
This diff view may be making it hard to see, but this condition wraps a test that used to set FIREFOX = false. See https://github.com/openlayers/openlayers/pull/7764/files#diff-7c3aa34c433b5b7112b6f12d7aeea7aaL86.
|
@marcjansen - I've addressed the previously failing test about line dashes by properly setting |
This reworks the
ol/hasmodule to use named exports.