Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named exports from ol/tilecoord #7791

Merged
merged 1 commit into from Feb 15, 2018

Conversation

marcjansen
Copy link
Member

@marcjansen marcjansen commented Feb 8, 2018

See #7779.

Please note that I changed the test createFromTemplates in tileurlfunction.test.js which used to override the hash method with sinon. I have removed most of the test and cannot say whether this is still testing anything useful.

Please review.

@marcjansen marcjansen changed the title WIP Named exports from tilecoord Named exports from ol/tilecoord Feb 15, 2018
Copy link
Member

@tschaub tschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcjansen!

@marcjansen
Copy link
Member Author

Thanks again, Tim.

@marcjansen marcjansen merged commit 3d4883f into openlayers:master Feb 15, 2018
@marcjansen marcjansen deleted the tilecoord-refactor branch June 28, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants