Mark optional property with square brackets #7975
Conversation
|
Will this also require work on the tools that create the typedefs for the Compiler? |
|
I think it's only for the api doc because the type are already optional (with the |
The babel-plugin-jsdoc-closure supports this already and creates a proper type for the Compiler. |
| * (defaults to `1000`). | ||
| * @property {undefined|function(number):number} easing The easing function used | ||
| * @property {number|undefined} [duration=1000] The duration of the animation in milliseconds. | ||
| * @property {undefined|function(number):number} [easing] The easing function used |
There was a problem hiding this comment.
Oh sorry for the inaccurate review. You should have removed the undefined in all places where you set the type in square parentheses. The babel-plugin-closure-jsdoc will resolve that to the correct type.
There was a problem hiding this comment.
Yes, I will do a follow-up pr
|
@fredj Can you please create a follow-up pull request to address #7975 (comment)? Thanks. |
No description provided.