Create separate target for linting generated files #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to ignore specific error codes (e.g. LINE_TOO_LONG) for externs, exports, types, etc. (any auto-generated files).
|
We've been getting lucky that our generated files pass the linter. The exports in #817 create /**
* @typedef {{opacity: (number|undefined),
* source: ol.source.Source,
* style: (ol.style.Style|undefined),
* transformFeatureInfo: (function(Array.<ol.Feature>):string|undefined),
* visible: (boolean|undefined)}}
*/
ol.layer.VectorLayerOptions;In order for the build to stop failing, we need to have more relaxed linting rules for generated files. |
|
Travis is happy, I'm happy, anybody else happy? |
|
I'm happy. This is a good solution. |
tschaub
added a commit
that referenced
this pull request
Jun 25, 2013
Create separate target for linting generated files
|
I'm happy too 😄 |
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
ability to switch between singleTile true and false on the fly (r=@ahocevar)
afabiani
pushed a commit
to geosolutions-it/openlayers
that referenced
this pull request
May 22, 2017
…ice versa, discussed change with @ahocevar see openlayers#821 for the details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to ignore specific error codes (e.g. LINE_TOO_LONG) for externs, exports, types, etc. (any auto-generated files).