Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New test runner #8883

Merged
merged 2 commits into from Nov 5, 2018
Merged

New test runner #8883

merged 2 commits into from Nov 5, 2018

Conversation

tschaub
Copy link
Member

@tschaub tschaub commented Nov 5, 2018

This updates the CircleCI config to run tests on Firefox and Chrome. With this change, we no longer run tests on IE. This is something we can revisit if it becomes a problem.

If others agree with this change, we can update the branch settings to require the CircleCI job to pass (and remove the Travis requirement).

Copy link
Member

@ahocevar ahocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice! Please merge!

@tschaub
Copy link
Member Author

tschaub commented Nov 5, 2018

Looks like some rendering tests are failing regularly on CircleCI's version of Firefox. See https://circleci.com/gh/openlayers/openlayers/23 for example.

The rendering tests are going to need a significant overhaul with the upcoming renderer changes (we will no longer have a single target canvas element for rendering). My plan was to separate out and simplify the rendering tests and run them with puppeteer. It would be nice to have cross-browser rendering and unit tests, but we could try simplifying and making the tests more reliable first and then rebuild cross-browser support if/when we feel like we need it.

@ahocevar
Copy link
Member

ahocevar commented Nov 5, 2018

For more reliable rendering tests, we'd also need to rework them to use larger reference images. For now, I'd say it's ok only test in Chrome.

@tschaub tschaub merged commit 42a094d into openlayers:master Nov 5, 2018
@tschaub tschaub deleted the new-ci branch November 5, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants