Fix zoom after export to PDF is done #9237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahocevar
reviewed
Feb 19, 2019
examples/export-pdf.js
Outdated
| @@ -64,6 +65,7 @@ exportButton.addEventListener('click', function() { | |||
| // Reset original map size | |||
| map.setSize(size); | |||
| map.getView().fit(extent, {size}); | |||
There was a problem hiding this comment.
Wouldn't it be enough to just change this line to
map.getView().fit(extent, {
size: size,
constrainResolution: false
});Then you could remove the rest of the changes.
There was a problem hiding this comment.
Totally right. Just provided your suggestion in the commit. Thanks.
|
If you format your code like in the snippet I provided, the CI will be happy. You can also test locally by running |
Just did it, thanks for making me discover lint! |
|
Thanks @umbe1987. |
ahocevar
approved these changes
Feb 19, 2019
|
With pleasure ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #9235