Skip to content

Conversation

@KaiVolland
Copy link
Contributor

This downgrades puppeteer to version ~1.11.0.

Version 1.11.x will download the stable version of chromium (72.0.3582.0), while version 1.12.x downloads the beta version of chromium (73.0.3679.0).

Fixes #9288

This downgrades puppeteer to version `~1.11.0`.
This will download the stable version of chromium
(72.0.3582.0). The current puppeteer version
(`^1.12.2`) downloads the beta version of
chromium (73.0.3679.0).
@marcjansen
Copy link
Member

This looks like the right change atm. we should carefully watch when greenkeeper wants to update this again.

@marcjansen marcjansen merged commit 1e06dd9 into openlayers:master Mar 6, 2019
@ahocevar
Copy link
Member

ahocevar commented Mar 7, 2019

Sorry for being late to the party, but I think the issue we were seeing here with Chromium 74 is something that's there to stay, and the issue will come up again when Chromium 74 is on the stable channel. This is also why I'm not opposed to use the dev version for running tests, because it helps us catch problems before the majority of users gets exposed to them.

Floating point arithmetics can always cause issues like this, so maybe doing a toFixed(Math.abs(exponent)) after Math.pow(base, exponent) for numbers lower than 1 with a negative exponent in the ScaleLine code would be appropriate?

@marcjansen
Copy link
Member

Fine for me, @KaiVolland can probably come up with a PR that addresses this. Thanks for the input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test (ol.control.ScaleLine)

3 participants