Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken in IE #44

Open
chaserx opened this issue Dec 3, 2015 · 13 comments

Comments

@chaserx
Copy link
Member

commented Dec 3, 2015

reported IE8 JS loading error. breaks the entire page. similar breakage in windows phone browser

“Tabletop is undefined”

@chaserx chaserx added this to the squishy launch milestone Dec 3, 2015

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2015

I don't have access to a windows machine, but we could probably look into a shortterm browserstack subscription

@eeeschwartz

This comment has been minimized.

Copy link
Member

commented Dec 5, 2015

I'm inclined to support IE9+ and watch the analytics to see how many IE8 and Windows Phone hits we get. Any thoughts?

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 5, 2015

That seems fine to support IE9+ if we can have an overlay directing users to another browser.

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2015

We could use something like http://outdatedbrowser.com/en but this too relies on JS and I think if there other JS errors as the Tabletop require error above that this may not be reliable.

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2015

Browserstack has offered us a subscription in return for public acknowledgement on project

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2015

screen shot 2015-12-24 at 10 18 57 am

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2015

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 24, 2015

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2015

if you add Tabletop into the shim section of script.js. You get past the tabletop not defined error but now you get this unhelpful error.

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C)
Timestamp: Sun, 27 Dec 2015 16:10:03 UTC


Message: Script error
Line: 0
Char: 0
Code: 0
URI: https://spreadsheets.google.com/feeds/worksheets/1ubx07oylGxk5FDIjMnQo4cMNBd3a8QYiPm27rWuyByI/public/basic?alt=json&callback=Tabletop.callbacks.tt14512325595743253
@chaserx

This comment has been minimized.

Copy link
Member Author

commented Dec 27, 2015

So... JSON validators hate the // API callback in the first line of the response from the spreadsheet URI above. I'm not sure how to fix that.

@eeeschwartz

This comment has been minimized.

Copy link
Member

commented Jan 27, 2016

I took a spin in IE11 and the live app is working well. Aside from the JSON validation, do you know of any other IE issues that should remain part of the soft launch?

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

no, i don't know of other issues.

@chaserx

This comment has been minimized.

Copy link
Member Author

commented Jan 27, 2016

it would be nice to have some indication that you must use a modern browser

@eeeschwartz eeeschwartz removed this from the squishy launch milestone Jan 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.