Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Up and down arrow key does nothing in search result. #7

Open
JunHuang01 opened this issue Jun 14, 2015 · 0 comments
Open

Up and down arrow key does nothing in search result. #7

JunHuang01 opened this issue Jun 14, 2015 · 0 comments

Comments

@JunHuang01
Copy link

@JunHuang01 JunHuang01 commented Jun 14, 2015

I've looked into this problem a little bit.

Up and down arrow key does nothing in search result keys are not working as one normally expect. And we are preventing anything from happening with

    this.inProgressSearch = _.debounce(function(ev) {
      ev.preventDefault();
      if (ev.keyCode === 13) { // Enter
        return;
      }

So basically I have a rough idea what needs to happen if we wants to enable hotkey on search result selection.

Let's talk about what exactly do we expect.

Do we expect that arrow key will move up and down in search results?

Do we expect when enter is hit, we would select the highlighted search result.

And in case the search query is not yet completely entered, but we do have a suggested search result, when enter is pressed at that point, that none other search result highlighted, and the search query is incomplete, we would show the suggested search result at that point?

And what I have in mind to get it to work is something like this:
http://stackoverflow.com/questions/17713520/enabling-keyboard-navigation-in-the-bootstrap-dropdown-menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.