Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web_url property assignment to getjson row reader #135

Merged

Conversation

ronnorthrip
Copy link
Collaborator

I changed the column header in production spreadsheet to match the pattern of the other headers and added a line to use that data as the web_url attribute. The rest just leverages code that was already in place.

This resolves issue #107 [non-facet data] add website for facilities information.

Copy link
Member

@chaserx chaserx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eeeschwartz eeeschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@eeeschwartz
Copy link
Member

@ronnorthrip all looks good. If you can resolve the merge conflict, I'll merge it.

…es_listing

# Conflicts:
#	src/data/geojson.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants