Remove download-osm make-dc, gen bbox #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify `download-osm` to only generate bbox value, without the overly complex (and unneeded) docker-compose config file. New functionality: * --bbox will generate a simple .env file with `BBOX=<....>` string. The value will be either computed based on the geofabrik's catalog, or for other sources it will continue using `osmconvert` * `download-osm bbox <pbf-file> <env-file>` will parse pbf file to generate the same .env file with bbox string * The --output param is now required when used with --bbox
TomPohys
approved these changes
Jun 16, 2020
TomPohys
approved these changes
Sep 28, 2020
|
Thanks @nyurik, looks great! |
|
Thanks @nyurik for simplifying the interface between There are significant difference between the the polygon bbox of openstreetmap.fr and the bbox computed by openstreetmap.fr has its polygons at Would it be possible to use them in For example, https://download.openstreetmap.fr/polygons/europe/monaco.poly is For our purpose, we only care about the |
|
@zstadler sure, we could improve the bbox generation further. Let me know if you want to submit a PR for that. |
|
Unfortunately, python is not my forte... |
zstadler
added a commit
to zstadler/openmaptiles
that referenced
this pull request
Oct 1, 2020
Currently, the `BBOX` setting in `.env` is ignored for all areas except `planet`. On the other hand, the `planet` area is an overkill for any `BBOX` setting other than the default - `-180.0,-85.0511,180.0,85.0511`. With this PR, `quickstart.sh` would not override a modified `BBOX` value in `.env`. Also, this provides a way to avoid the pessimistic `BBOX` computation for `osmfr` extracts, as described in openmaptiles/openmaptiles-tools#297 (comment)
https://github.com/ustroetz/polygon2osm/blob/master/polygon2geojson.py converts a |
TomPohys
pushed a commit
to openmaptiles/openmaptiles
that referenced
this pull request
Oct 15, 2020
* Allow setting `BBOX` to be set in `.env` file Currently, the `BBOX` setting in `.env` is ignored for all areas except `planet`. On the other hand, the `planet` area is an overkill for any `BBOX` setting other than the default - `-180.0,-85.0511,180.0,85.0511`. With this PR, `quickstart.sh` would not override a modified `BBOX` value in `.env`. Also, this provides a way to avoid the pessimistic `BBOX` computation for `osmfr` extracts, as described in openmaptiles/openmaptiles-tools#297 (comment) #### Currently - If the user does not do anything, `quickstart.sh` and `make generate-tiles` create an `mbtiles` file for the full extent of the data source. This applies to `planet` and other data sources. - If a user sets the `BBOX` value in `.env` and a `planet` data source is used, `quickstart.sh` and `make generate-tiles` create an `mbtiles` file for the extent set in the `.env` file. - If a user sets the `BBOX` value in `.env` and a non-`planet` data source is used, it is ignored - `quickstart.sh` and `make generate-tiles` create an `mbtiles` file for the full extent of the data source. #### Problem statement While users of a `planet` data source have a simple way to override the default extend of the tile generation, users of other data sources have no simple way of doing that. In fact, for such users the `BBOX` setting in the `.env` file is ignored and therefore misleading. #### Proposal - If the user does not do anything, `quickstart.sh` and `make generate-tiles` create an `mbtiles` file for the full extent of the data source. This applies to `planet` and other data sources. - If a user sets the `BBOX` value in `.env`, `quickstart.sh` and `make generate-tiles` create an `mbtiles` file for the extent set in the `.env` file. This applies to `planet` and other data sources.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
download-osmto only generate bbox value, without the overly complex (and unneeded) docker-compose config file.New functionality:
--bboxwill generate a simple text file containing the bounding box string. The value will be either computed based on the geofabrik's catalog, or for other sources it will continue usingosmconvertdownload-osm bbox <pbf-file> <bbox-file>will parse pbf file to generate the same text file with bbox string--outputparam is now required when used with--bboxRemoved functionality:
--make-dcparameter andmake-dccommand.