Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tally filter for first-flight collision probabilites #960

Open
smharper opened this issue Jan 26, 2018 · 7 comments
Open

Tally filter for first-flight collision probabilites #960

smharper opened this issue Jan 26, 2018 · 7 comments

Comments

@smharper
Copy link
Contributor

It would be handy if we could compute first-flight collision probabilities. I imagine we could do it by adding something like last_collision_material to the particle header which tells us in which material the particle had its last collision (or was born). Then we could filter it with a LastCollisionMaterialFilter that would be similar in implementation to a MaterialFilter.

@johnnyliu27, would you like to tackle this issue?

@johnnyliu27
Copy link
Contributor

Sure I’d like to give a try on this. Regarding to the future implementation of CMM, a variable in the particle header recording the neutron’s birth place will be definitely more useful for CMM.
I’ll update here when I get into more details on this.

@EinKaiser
Copy link

Hi, can I have a go at this?

@paulromano
Copy link
Contributor

@johnnyliu27 Did you ever work on this or is it ok for @EinKaiser to give it a shot?

@johnnyliu27
Copy link
Contributor

Feel free to take this issue @EinKaiser since I didn't go too far on it. Thanks!

@maxtriano
Copy link

maxtriano commented Feb 20, 2024

Is this still open? Can give it a try if so

@pshriwise
Copy link
Contributor

Hi @maxtriano, I think this is all yours if you want to take a crack at it!

@maxtriano
Copy link

Would this last_collision_material be different from material_last_ which is currently stored in GeometryState? In that case, all that needs to be done is to add a LastCollisionMaterialFilter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants