Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting surf_source_ attribute for DAGMC surfaces. #2857

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

pshriwise
Copy link
Contributor

@pshriwise pshriwise commented Jan 23, 2024

Description

Addresses empty surface source files when this feature is applied to DAGMC surfaces. This is because the DAGSurface::surf_source_ attribute isn't being set. DAGSurface's aren't created using the XML node constructor and in turn don't apply the code from the Surface::Surface(pugi::xml_node node) surface constructor.

This simply adds the same check in the DAGSurface constructor. In addition to a min-test that particles are generated in the correct location (on the barrel of surafce 1). I then put together a quick and dirty external source site display feature in the plotter to prove to myself it was working using the fuel pin regression test:

note:: source sites are projected onto the slice plane regardless of whether or not they are on or approximately on that plane

Model (colored by cell)

image

Surface 1 (cylinder barrel)

image

Surface 2 (lower Z surface)

image

Surface 3 (upper Z surface)

image

Surfaces 1, 2, and 3

image

image

Fixes #2856

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pshriwise!

@paulromano paulromano enabled auto-merge (squash) January 29, 2024 21:00
@paulromano paulromano merged commit cb7ef00 into openmc-dev:develop Jan 30, 2024
17 checks passed
church89 pushed a commit to openmsr/openmc that referenced this pull request Jul 18, 2024
Co-authored-by: Paul Romano <paul.k.romano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface source sites not generated for DAGMC surfaces
2 participants