Use non-deprecated methods for getting libMesh node points#3963
Merged
Conversation
Contributor
Author
|
@pshriwise easy one for ya. |
f9d1b37 to
80c8283
Compare
nuclearkevin
approved these changes
Jun 8, 2026
Member
There was a problem hiding this comment.
Thanks @loganharbour! If @pshriwise doesn't have any problems with this, I'll merge it in a day or two.
pshriwise
approved these changes
Jun 9, 2026
pshriwise
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks @loganharbour!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "copy" constructor for Node (see https://github.com/libMesh/libmesh/blob/cc84387bbd96e12d2d12986402ec8bba282fc0c4/include/geom/node.h#L76) is deprecated.
Builds with current libmesh with
--disable-deprecatedwill fail to compile. Get a reference to the node and useoperator()(from parentPoint) instead.See these build failures from Salamander (with cardinal and libmesh
--disable-deprecated):Checklist