fix cluster's Scheme() method in test setups #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
Scheme()method of theClustertype did returnnil, if the internalcluster.Clusterwas nil, even if the internalclient.Clientwas not and returning a scheme would have been possible. TheNewTestClusterFromClientconstructor which can be used to construct a 'fake'Clusterfor testing purposes returns exactly aClusterinstance where the internalcluster.Clusteris nil, but the internalclient.Clientis not.The old implementation of the
Schememethod therefore prevents any code from using it if said code is being tested with aClusterconstructed with theNewTestClusterFromClientfunction.This PR fixes the problem by returning the internal
client.Client's scheme as a fallback, if the internalcluster.Clusteris nil. TheSchememethod should now only returnnil, if both, the internal cluster and the internal client, are nil.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Release note: