fix condition updater #93
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a bug in the condition updater that could lead to a condition's
LastTransitionTimewrongfully being updated if the status did not change. The bug would occur if the same condition was updated multiple times, with any update changing the status and the last update reverting it back to the original value.Also ensures that conditions always have a non-empty reason set, because the metav1.Condition type requires that and updating the k8s resource will fail if any condition is lacking the reason. If the reason is missing, the condition updater now sets a dummy value that is a concatenation of the condition's type and its status.
Adds a
GenerateCreateConditionFuncto thepkg/controllerpackage.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
This PR includes a patch release.
Release note: