Skip to content

Conversation

@robertgraeff
Copy link
Member

@robertgraeff robertgraeff commented Nov 11, 2025

What this PR does / why we need it:

With this pull request, the TLS port on which the gateways are listening is configurable. The configuration of the TLS port is optional. The default port is 9443.

apiVersion: gateway.openmcp.cloud/v1alpha1
kind: GatewayServiceConfig
metadata:
  name: gateway
spec:
  clusters:
    ...
  envoyGateway:
    ...
  dns:
    ...
  gateway:
    tlsPort: <CONFIGURED TLS PORT>  # optional, default 9443

Effect on the gateway:

apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  annotations:
    ...
    gateway.openmcp.cloud/tls-port: <CONFIGURED TLS PORT>
  ...
spec:
  ...
  listeners:
  - name: tls
    port: <CONFIGURED TLS PORT>
    protocol: TLS
    ...

Which issue(s) this PR fixes:

Fixes #15

Special notes for your reviewer:

Release note:

-  The TLS port on which the gateways are listening is configurable.

type GatewayConfig struct {
// TLSPort is the port on which the gateway will listen for TLS traffic.
// +kubebuilder:default=9443
TLSPort int32 `json:"tlsPort,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking: Can we change this to int? Then we don't need the int(...) conversion in pkg/envoy/config.go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the Gateway API is using int32. Then we can also leave it like that :)

@robertgraeff robertgraeff merged commit d0ad27d into main Nov 12, 2025
7 checks passed
@robertgraeff robertgraeff deleted the feat/tls-port branch November 12, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make TLS port configurable

3 participants