From c097eba8234c1b4d86e1141742e33d81e2779f00 Mon Sep 17 00:00:00 2001 From: Lasserich Date: Fri, 29 Aug 2025 18:03:10 +0200 Subject: [PATCH 1/3] fix: banner size --- .../ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | 1 + src/components/Shared/IllustratedError.tsx | 4 +++- src/components/Ui/IllustratedBanner/IllustratedBanner.tsx | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx b/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx index f880e450..42e61026 100644 --- a/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx +++ b/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx @@ -58,6 +58,7 @@ export function ControlPlaneListWorkspaceGridTile({ projectName, workspace }: Pr ); } else { diff --git a/src/components/Shared/IllustratedError.tsx b/src/components/Shared/IllustratedError.tsx index 701e7528..533764c7 100644 --- a/src/components/Shared/IllustratedError.tsx +++ b/src/components/Shared/IllustratedError.tsx @@ -6,9 +6,10 @@ import IllustrationMessageType from '@ui5/webcomponents-fiori/dist/types/Illustr interface Props { title?: string; details?: string; + compact?: boolean; } -export default function IllustratedError({ title, details }: Props) { +export default function IllustratedError({ title, details, compact }: Props) { const { t } = useTranslation(); return ( @@ -16,6 +17,7 @@ export default function IllustratedError({ title, details }: Props) { illustrationName={IllustrationMessageType.SimpleError} title={title ?? t('IllustratedError.titleText')} subtitle={details ?? t('IllustratedError.subtitleText')} + compact = {compact} /> ); } diff --git a/src/components/Ui/IllustratedBanner/IllustratedBanner.tsx b/src/components/Ui/IllustratedBanner/IllustratedBanner.tsx index 6a498c27..8e273b8b 100644 --- a/src/components/Ui/IllustratedBanner/IllustratedBanner.tsx +++ b/src/components/Ui/IllustratedBanner/IllustratedBanner.tsx @@ -36,7 +36,7 @@ export const IllustratedBanner = ({ return ( Date: Mon, 1 Sep 2025 13:08:47 +0200 Subject: [PATCH 2/3] fix: more banner --- .../ComponentsSelection/ComponentsSelectionContainer.tsx | 4 ++-- src/components/ControlPlane/FluxList.tsx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx b/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx index b119d048..6dd79fb6 100644 --- a/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx +++ b/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx @@ -69,12 +69,12 @@ export const ComponentsSelectionContainer: React.FC = } if (error) { - return ; + return ; } // Defensive: If the API returned no items, show error if (!componentsList || componentsList.length === 0) { - return ; + return ; } return ; diff --git a/src/components/ControlPlane/FluxList.tsx b/src/components/ControlPlane/FluxList.tsx index d9865446..ccbf5f18 100644 --- a/src/components/ControlPlane/FluxList.tsx +++ b/src/components/ControlPlane/FluxList.tsx @@ -136,6 +136,7 @@ export default function FluxList() { ); } From 9017e90ba19ab1f32838907af88e5a39616de8a3 Mon Sep 17 00:00:00 2001 From: Lasserich Date: Mon, 1 Sep 2025 13:13:32 +0200 Subject: [PATCH 3/3] fix: linting --- .../ComponentsSelection/ComponentsSelectionContainer.tsx | 2 +- .../ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx | 2 +- src/components/Shared/IllustratedError.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx b/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx index 6dd79fb6..a836b5e1 100644 --- a/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx +++ b/src/components/ComponentsSelection/ComponentsSelectionContainer.tsx @@ -69,7 +69,7 @@ export const ComponentsSelectionContainer: React.FC = } if (error) { - return ; + return ; } // Defensive: If the API returned no items, show error diff --git a/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx b/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx index 42e61026..c7469c7f 100644 --- a/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx +++ b/src/components/ControlPlanes/List/ControlPlaneListWorkspaceGridTile.tsx @@ -58,7 +58,7 @@ export function ControlPlaneListWorkspaceGridTile({ projectName, workspace }: Pr ); } else { diff --git a/src/components/Shared/IllustratedError.tsx b/src/components/Shared/IllustratedError.tsx index 533764c7..5ba5cf2c 100644 --- a/src/components/Shared/IllustratedError.tsx +++ b/src/components/Shared/IllustratedError.tsx @@ -6,7 +6,7 @@ import IllustrationMessageType from '@ui5/webcomponents-fiori/dist/types/Illustr interface Props { title?: string; details?: string; - compact?: boolean; + compact?: boolean; } export default function IllustratedError({ title, details, compact }: Props) { @@ -17,7 +17,7 @@ export default function IllustratedError({ title, details, compact }: Props) { illustrationName={IllustrationMessageType.SimpleError} title={title ?? t('IllustratedError.titleText')} subtitle={details ?? t('IllustratedError.subtitleText')} - compact = {compact} + compact={compact} /> ); }