Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remove filesystem label support #152

Open
votdev opened this Issue Jul 29, 2018 · 5 comments

Comments

Projects
4 participants
@votdev
Copy link
Collaborator

votdev commented Jul 29, 2018

Remove the support of filesystem labels because it makes more troubles (see #151) as it helps. This means that labels can be set when a filesystem is created, but OMV will not use them to identify the device file via /dev/disk/by-label/xxxx.

@votdev votdev added this to To do in 5.x Jul 29, 2018

@momo42

This comment has been minimized.

Copy link

momo42 commented Aug 27, 2018

Please leave label support in! It helps a lot if you have multiple filesystems. I think it would be better to check for existing labels when adding new disk labels.

@votdev

This comment has been minimized.

Copy link
Collaborator Author

votdev commented Aug 27, 2018

I think it would be better to check for existing labels when adding new disk labels.

This is already done

@votdev

This comment has been minimized.

Copy link
Collaborator Author

votdev commented Aug 27, 2018

One of many examples where filesystem labels make problems:

@votdev votdev changed the title Remove filesystem label support Proposal: Remove filesystem label support Sep 10, 2018

@klorinczi

This comment has been minimized.

Copy link

klorinczi commented Oct 1, 2018

I also use filesystem labels, I would ask to keep it.

@Samuel12321

This comment has been minimized.

Copy link

Samuel12321 commented Nov 29, 2018

perhaps it would be best if the user can turn this on of off, depending on whether they need/want filesystem labels or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.