Skip to content

[feature reqest] Create a user or installation setting for number of items per page. #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DjoeC opened this issue Jul 19, 2024 · 9 comments

Comments

@DjoeC
Copy link

DjoeC commented Jul 19, 2024

Is your feature request related to a problem? Please describe.
On a large screen it is frustrating to have a maximum of 25 visible items. On a mobile device when more than 25 items are available it requires some scrolling, followed by paging - 2 different actions. Being able to have "all" or some user-determined arbitrary number or choice from a number of presets, saved between sessions, would be a nice enhancement.

Describe the solution you'd like
I would like a per user/installation setting of the (maximum) number of items per page. Refer to the "limit" property.

Describe alternatives you've considered
Currently there is no alternative but the standard limit of 25 items per page other than a (local) code adjustment.

Additional context
According to post https://forum.openmediavault.org/index.php?thread/53333-possible-to-increase-number-of-items-per-page-in-services-compose-files-containe/&postID=396202#post396202 the enhancement should be possible.

I understand that with summer being here it will not have great priority BUT the enhancement would be greatly appreciated.

@DjoeC DjoeC added the feature label Jul 19, 2024
@votdev
Copy link
Member

votdev commented Jul 30, 2024

The used datatable component does not support that out-of-the-box.

Copy link

This issue has been automatically marked as stale because it
has not had any activity for 60 days. It will be closed if no further
activity occurs for another 30 days.

@DjoeC
Copy link
Author

DjoeC commented Sep 28, 2024

@votdev Thanks for keeping this alive as I would still like to have the option. And sorry for not being able to contribute code myself.

@a-st
Copy link

a-st commented Jan 22, 2025

@votdev I'm currently preparing a PR for this. Would something like that be acceptable?

Image

Image

a-st pushed a commit to a-st/openmediavault that referenced this issue Jan 22, 2025
…r of items per page

Value is stored in local storage and restored on login
a-st added a commit to a-st/openmediavault that referenced this issue Jan 22, 2025
…r of items per page

Value is stored in local storage and restored on login

Signed-off-by: Alexander Straube <alexander.straube@gmail.com>
a-st added a commit to a-st/openmediavault that referenced this issue Jan 22, 2025
Signed-off-by: Alexander Straube <alexander.straube@gmail.com>
@DjoeC
Copy link
Author

DjoeC commented Jan 22, 2025

@votdev I'm currently preparing a PR for this. Would something like that be acceptable?

Image

Image

Also an "all" (or "0"=all) option?

Thanks!

a-st added a commit to a-st/openmediavault that referenced this issue Jan 22, 2025
Signed-off-by: Alexander Straube <alexander.straube@gmail.com>
@a-st
Copy link

a-st commented Jan 22, 2025

@DjoeC Good call. The input now allows all values >= 0 with 0=all

@DjoeC
Copy link
Author

DjoeC commented Jan 22, 2025

@DjoeC Good call. The input now allows all values >= 0 with 0=all

Super!!

@votdev
Copy link
Member

votdev commented Jan 22, 2025

Thank you for the initial contribution. But to be honest, I don't like the solution and implementation at all.
From a UX perspective, this dropdown belongs in the pagination bar.
The solution with the service that stores the settings in the browser session does not harmonize at all with the implementation of the user settings such as the columns to be displayed or the sorting order of the table which is stored in the backend.
I have high expectations for the OMV UI. That's why I haven't implemented this functionality myself yet, because I didn't like any of the solutions I came up with. Customizing the pagination bar requires a lot of effort.

@DjoeC
Copy link
Author

DjoeC commented Jan 22, 2025

Ahha yes definitely not a browser setting. Like (many?) other users I don't save browser settings (cookies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants