Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat req. improve information displayed at fs panel #490

Open
subzero79 opened this issue Nov 4, 2019 · 4 comments

Comments

@subzero79
Copy link
Contributor

@subzero79 subzero79 commented Nov 4, 2019

Description of issue/question

The backend retrieves the same information for device, parent device and device(s) all display the same. This is a ss of the panel mostly composed of logical volumes, which all of them (except EFI) have they have identifying names in the device mapper path.

image

dev/disk$ tree -a
.
├── by-id
│   ├── dm-name-data-storage -> ../../dm-2
│   ├── dm-name-data_storage--vg-music -> ../../dm-5
│   ├── dm-name-data_storage--vg-other -> ../../dm-3
│   ├── dm-name-data_storage--vg-pictures -> ../../dm-6
│   ├── dm-name-data_storage--vg-videos -> ../../dm-4
│   ├── dm-name-elqui--vg-root -> ../../dm-0
│   ├── dm-name-elqui--vg-swap_1 -> ../../dm-1
│   ├── dm-uuid-CRYPT-LUKS2-256b1a69064344388bded917abe90459-data-storage -> ../../dm-2
│   ├── dm-uuid-LVM-PfftZ13Qtw1N97yE41a8ctuxTGXjtGvU7qZCScUJvoAivi83MJf7jNYqmBGUZAYU -> ../../dm-5
│   ├── dm-uuid-LVM-PfftZ13Qtw1N97yE41a8ctuxTGXjtGvUFQtv0ykgIFZYxuBJt5E07c4DGgNrHefY -> ../../dm-4
│   ├── dm-uuid-LVM-PfftZ13Qtw1N97yE41a8ctuxTGXjtGvUWIs27V7TpX6EsxTWZWw2pxgZn4kl1GoC -> ../../dm-3
│   ├── dm-uuid-LVM-PfftZ13Qtw1N97yE41a8ctuxTGXjtGvUYNo6eh2HK6gtAQiQtUpWhKBjql9GrtCU -> ../../dm-6
│   ├── dm-uuid-LVM-uSB3m1gZWMLpF4CL5HCQguRp3wZ5k2leZSxIVR1CeEJfPdECkcdfVko3E37KmlRF -> ../../dm-1
│   ├── dm-uuid-LVM-uSB3m1gZWMLpF4CL5HCQguRp3wZ5k2leaeEPqE1AVXAtM2VCfkuQQU7aFD5XrXNi -> ../../dm-0
│   ├── lvm-pv-uuid-IWJ2mR-AX3M-k9ZY-SAfq-ZCvj-zO47-CZWK6v -> ../../dm-2
│   ├── lvm-pv-uuid-hgcQaJ-PpkP-0tdN-847X-mGI1-yMek-A9zRzW -> ../../sda
│   ├── scsi-0QEMU_QEMU_HARDDISK_drive-scsi0 -> ../../sda
│   ├── scsi-0QEMU_QEMU_HARDDISK_drive-scsi1 -> ../../sdb
│   ├── scsi-0QEMU_QEMU_HARDDISK_drive-scsi1-part1 -> ../../sdb1
│   └── scsi-0QEMU_QEMU_HARDDISK_drive-scsi2 -> ../../sdc
├── by-label
│   ├── EFI -> ../../sdb1
│   ├── music -> ../../dm-5
│   ├── other -> ../../dm-3
│   ├── pictures -> ../../dm-6
│   ├── rootfs -> ../../dm-0
│   ├── rust-storage\x2fvm-111-disk-0 -> ../../sdc
│   └── videos -> ../../dm-4
├── by-partuuid
│   └── 1890835c-01 -> ../../sdb1
├── by-path
│   ├── pci-0000:01:01.0-scsi-0:0:0:0 -> ../../sda
│   ├── pci-0000:01:02.0-scsi-0:0:0:1 -> ../../sdb
│   ├── pci-0000:01:02.0-scsi-0:0:0:1-part1 -> ../../sdb1
│   └── pci-0000:01:03.0-scsi-0:0:0:2 -> ../../sdc
└── by-uuid
    ├── 0293545a-d0bd-4263-91bc-5ceabd055cb9 -> ../../dm-0
    ├── 198a34a8-5992-4ffa-8f6d-416665d5f7b4 -> ../../dm-6
    ├── 256b1a69-0643-4438-8bde-d917abe90459 -> ../../sdc
    ├── 3866063e-be48-41f9-a650-b158635234c8 -> ../../dm-1
    ├── 5525-F951 -> ../../sdb1
    ├── ed4e1388-e3dd-42b9-8bf6-37826b14c850 -> ../../dm-5
    ├── f3fc9576-26f2-4aa8-9dd0-61d8b67ab995 -> ../../dm-4
    └── f609aeda-2e89-43bd-b648-f7e36d3c2e2a -> ../../dm-3
:/dev/mapper$ tree -a
.
├── control
├── data-storage -> ../dm-2
├── data_storage--vg-music -> ../dm-5
├── data_storage--vg-other -> ../dm-3
├── data_storage--vg-pictures -> ../dm-6
├── data_storage--vg-videos -> ../dm-4
├── elqui--vg-root -> ../dm-0
└── elqui--vg-swap_1 -> ../dm-1

0 directories, 8 files

In this case i am helping myself identifying by labels

Steps to reproduce issue

(Include debug logs if possible and relevant.)

Versions report

@votdev

This comment has been minimized.

Copy link
Collaborator

@votdev votdev commented Nov 4, 2019

You know from the forum that labels, and explicit /dev/disk/by-label, is a bad idea. Or how shall i understand this feature rrequest.

@subzero79

This comment has been minimized.

Copy link
Contributor Author

@subzero79 subzero79 commented Nov 4, 2019

Sorry i didn't explain better. It would be better to help identify the the devices associated to the fs if the dev/by-id or for LVM the mapper device name would be displayed there, i am not saying we change how we mount devices.

In this case i am saying the only thing helping me identify each fs to a device is the label.

Look here before formatting

Screenshot_2019-11-04_22-10-18

Shouldn't we display that in at least one of the columns, or a new one.

Even for a brief moment during fs initialisation you can see the /dev/mapper name, then it goes into canonical dm-X name

I haven't use omv in bare metal since a long time but i guess it would be the same for directly attached disks

@votdev

This comment has been minimized.

Copy link
Collaborator

@votdev votdev commented Nov 4, 2019

Can you re-upload the image please, it's not visible.

@subzero79

This comment has been minimized.

Copy link
Contributor Author

@subzero79 subzero79 commented Nov 5, 2019

i've updated the screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.