New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerous Rsync server bug: Syncing OMV to a backup OMV server deletes all files #86

Open
sudoquai opened this Issue Apr 18, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@sudoquai

sudoquai commented Apr 18, 2018

I've discovered a dangerous bug with Rsync server:

My NAS setup consists of two OMV servers each with 1 data drive. The main server is running rsync as server. The backup server is configured to synchronize all data 1:1 with the main server over rsync (configured over web interface). Therefore a rsync job was configured to pull the data from the main server.

If the data drive of the main server is now removed / broken or similar and the rsync pull job still running (cron job configured in the rsync module in web interface) all data will be erased !

This encounters if you configure this rsync job as a cron job over the rsync setting interface with rsync option "Delete files on the receiving side which doesn't exist on sender".

You can test it with rsync option "--dry-run" and a backup server installed in Virtualbox with external USB drive. Sync on time, and second time just disconnect the data drive in your main OMV before the rsync job is running and see what happens ...

Please get sure that rsync server is NOT running or data not available in case the data share points to a missing or broken drive !

Does somebody have a workaround solution for this case until this issue is solved ?

Thx.

@votdev

This comment has been minimized.

Collaborator

votdev commented Apr 18, 2018

You're sure, this is a dangerous behaviour, but i do not see any fault in OMV here nor a solution to fix that. But i'm open for useful PR's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment