Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::shared_ptr instead of our own RC* function. #396

Closed
wants to merge 23 commits into from
Closed

Conversation

@papadop
Copy link
Contributor

papadop commented Dec 5, 2019

This PR removes the use of our own shared pointer solution in favor of the standard std::shared_ptr. Hopefully it will also help to improve the python binding as the std::shared_ptr is already handled by swig. This also remove some files which we no longer have to maintain and simplifies a little bit the code. Tested on fedora 31, let's see what the other platforms will say....

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #396 into master will decrease coverage by 1.02%.
The diff coverage is 78.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #396      +/-   ##
==========================================
- Coverage   70.09%   69.07%   -1.03%     
==========================================
  Files          96       92       -4     
  Lines        6604     6625      +21     
==========================================
- Hits         4629     4576      -53     
- Misses       1975     2049      +74
Impacted Files Coverage Δ
OpenMEEGMaths/src/symmatrix.cpp 59.59% <0%> (ø) ⬆️
OpenMEEGMaths/src/matrix.cpp 76.71% <100%> (ø) ⬆️
OpenMEEGMaths/include/linop.h 92.85% <71.42%> (+12.85%) ⬆️
OpenMEEGMaths/include/vector.h 57.4% <75%> (ø) ⬆️
OpenMEEGMaths/include/symmatrix.h 45.83% <85.71%> (ø) ⬆️
OpenMEEGMaths/include/matrix.h 77.59% <87.5%> (-0.18%) ⬇️
OpenMEEG/include/Triangle_triangle_intersection.h 17.32% <0%> (-29.14%) ⬇️
OpenMEEG/include/geometry.h 74.28% <0%> (-21.87%) ⬇️
OpenMEEG/include/mesh.h 65.3% <0%> (-17.75%) ⬇️
OpenMEEG/include/vertex.h 87.5% <0%> (-12.5%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fbd380...97508db. Read the comment docs.

papadop added 9 commits Dec 6, 2019
papadop added 12 commits Dec 7, 2019
@papadop

This comment has been minimized.

Copy link
Contributor Author

papadop commented Dec 14, 2019

Replaced by PR #399 .

@papadop papadop closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.