Skip to content

feat(pkg): add time filter#2410

Merged
tothandras merged 1 commit into
mainfrom
feat/filter
Mar 11, 2025
Merged

feat(pkg): add time filter#2410
tothandras merged 1 commit into
mainfrom
feat/filter

Conversation

@tothandras
Copy link
Copy Markdown
Contributor

@tothandras tothandras commented Mar 11, 2025

Summary by CodeRabbit

  • New Features

    • Introduced advanced date-time filtering options, enabling conditions like greater than, greater than or equal to, less than, and less than or equal to a specified date-time.
    • Supported logical combination of multiple filter conditions using AND/OR operators.
  • Tests

    • Expanded test coverage to verify the reliability and expected behavior of the new time-based filtering functionality.

@tothandras tothandras added the release-note/ignore Ignore this change when generating release notes label Mar 11, 2025
@tothandras tothandras requested a review from a team as a code owner March 11, 2025 11:57
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 11, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes introduce a new FilterTime schema and model to the API and filtering logic, allowing for time-based filtering. The FilterTime schema supports comparison operators ($gt, $gte, $lt, $lte) and logical combinations using $and and $or. In the backend, a corresponding FilterTime type is implemented with validation and SQL expression generation methods. Additionally, tests have been added to ensure the functionality of the new time-based filters.

Changes

Files Change Summary
api/…/openapi.yaml, api/…/filter.tsp Added a new FilterTime schema/model that supports time-based filtering with options for greater than, greater than or equal to, less than, less than or equal to, and logical operators.
pkg/filter/…/filter.go, pkg/filter/…/filter_test.go Implemented a FilterTime type with Validate and SelectWhereExpr methods, updated the Filter interface, and added tests to validate and generate SQL expressions for time filters.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0f5ffe and fa18470.

📒 Files selected for processing (4)
  • api/openapi.yaml (1 hunks)
  • api/spec/src/filter.tsp (1 hunks)
  • pkg/filter/filter.go (5 hunks)
  • pkg/filter/filter_test.go (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tothandras tothandras merged commit c425d7b into main Mar 11, 2025
@tothandras tothandras deleted the feat/filter branch March 11, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ignore Ignore this change when generating release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants