Skip to content

fix(sink): tracing#3967

Merged
tothandras merged 1 commit into
mainfrom
fix/sink-worker-tracing
Mar 18, 2026
Merged

fix(sink): tracing#3967
tothandras merged 1 commit into
mainfrom
fix/sink-worker-tracing

Conversation

@tothandras
Copy link
Copy Markdown
Contributor

@tothandras tothandras commented Mar 18, 2026

Summary by CodeRabbit

Release Notes

New Features

  • Integrated distributed tracing support to enhance observability of event callbacks and message processing workflows, enabling improved monitoring and troubleshooting of sink operations across message delivery pipelines.

Improvements

  • Enhanced trace context propagation throughout callback execution paths for comprehensive visibility into asynchronous message handling operations.

@tothandras tothandras requested a review from a team as a code owner March 18, 2026 14:19
@tothandras tothandras added the release-note/bug-fix Release note: Bug Fixes label Mar 18, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b630857a-7257-4667-a0bf-1ef1792816c8

📥 Commits

Reviewing files that changed from the base of the PR and between 8243d0a and 5e7b062.

📒 Files selected for processing (1)
  • openmeter/sink/flushhandler/handler.go

📝 Walkthrough

Walkthrough

This change integrates OpenTelemetry tracing into the flush handler by capturing parent spans from the start context and propagating them through callback invocations and drain paths. The invokeCallbackWithTimeout method signature is updated to accept a trace.Span parameter for linking callbacks to the parent trace context.

Changes

Cohort / File(s) Summary
OpenTelemetry Tracing Integration
openmeter/sink/flushhandler/handler.go
Added span context propagation to invokeCallbackWithTimeout method. Captures parent span from start context and threads it through callback invocation and drain paths to maintain trace continuity.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix(sink): tracing' is vague and doesn't clearly convey what tracing issue was fixed or how it relates to the sink component. Consider a more descriptive title like 'fix(sink): add OpenTelemetry tracing integration to flush handler' to better explain the actual changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sink-worker-tracing
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tothandras tothandras merged commit 71e6231 into main Mar 18, 2026
27 of 28 checks passed
@tothandras tothandras deleted the fix/sink-worker-tracing branch March 18, 2026 14:33
mark-vass-konghq pushed a commit that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/bug-fix Release note: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants