chore: support effective at on stdinvoice

[turip]

support effective_at on stdinvoice

Summary by CodeRabbit

• Bug Fixes
  • Corrected credit purchase invoice settlement timing calculation to align with the intent's effective computation, improving billing accuracy.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 074dd717-158e-487d-b02c-7a28903f75bf

📥 Commits

Reviewing files that changed from the base of the PR and between 7282388 and 5f9ad62.

📒 Files selected for processing (1)

• openmeter/billing/charges/creditpurchase/service/create.go

---

📝 Walkthrough

Walkthrough

Updated the invoice scheduling timestamp calculation in credit purchase gathering line creation to use CalculateEffectiveAt() instead of the raw service period start timestamp, shifting from unadjusted to computed effective timing for invoice settlement.

Changes

Cohort / File(s)	Summary
Credit Purchase Invoice Timing openmeter/billing/charges/creditpurchase/service/create.go	Modified buildInvoiceCreditPurchaseGatheringLine to use computed effective timestamp (intent.CalculateEffectiveAt()) instead of raw service period start (intent.ServicePeriod.From) for the InvoiceAt field.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions 'effective at on stdinvoice' which aligns with the code change that updates invoice scheduling to use intent.CalculateEffectiveAt(), making it relevant to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/support-effective-at-on-stdinvoice

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}