Skip to content

chore(api): update v3 extensions#4281

Merged
tothandras merged 1 commit into
mainfrom
chore/api-v3-visibility
May 4, 2026
Merged

chore(api): update v3 extensions#4281
tothandras merged 1 commit into
mainfrom
chore/api-v3-visibility

Conversation

@tothandras
Copy link
Copy Markdown
Contributor

@tothandras tothandras commented May 4, 2026

Summary by CodeRabbit

  • Chores
    • Updated API specification extension metadata across multiple operation modules (events, features, meters, product catalog, and tax operations) to reflect revised visibility classifications.
    • Regenerated embedded OpenAPI specification payload to incorporate the updated operation definitions.

@tothandras tothandras requested a review from a team as a code owner May 4, 2026 11:35
@tothandras tothandras added the release-note/ignore Ignore this change when generating release notes label May 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 50495758-b85a-4bc5-99fa-eec6d386b423

📥 Commits

Reviewing files that changed from the base of the PR and between bc11393 and e308ba3.

⛔ Files ignored due to path filters (1)
  • api/v3/openapi.yaml is excluded by !**/openapi.yaml
📒 Files selected for processing (6)
  • api/spec/packages/aip/src/events/operations.tsp
  • api/spec/packages/aip/src/features/operations.tsp
  • api/spec/packages/aip/src/meters/operations.tsp
  • api/spec/packages/aip/src/productcatalog/operations.tsp
  • api/spec/packages/aip/src/tax/operations.tsp
  • api/v3/api.gen.go
💤 Files with no reviewable changes (1)
  • api/spec/packages/aip/src/tax/operations.tsp

📝 Walkthrough

Walkthrough

This PR updates API operation visibility metadata across multiple TypeSpec specification files, changing extension annotations from InternalExtension to PrivateExtension in events, features, meters, and product catalog operations, while removing InternalExtension entirely from tax operations. The regenerated Go API spec reflects these changes.

Changes

Extension Metadata Updates

Layer / File(s) Summary
Extension Decorator Updates
api/spec/packages/aip/src/events/operations.tsp, api/spec/packages/aip/src/features/operations.tsp, api/spec/packages/aip/src/meters/operations.tsp, api/spec/packages/aip/src/productcatalog/operations.tsp
Operations updated from @extension(Shared.InternalExtension, true) to @extension(Shared.PrivateExtension, true) across list, create, get, update, delete, and domain-specific action operations.
Extension Removal
api/spec/packages/aip/src/tax/operations.tsp
@extension(Shared.InternalExtension, true) decorator completely removed from create-tax-code, get-tax-code, list-tax-codes, upsert-tax-code, and delete-tax-code operations.
Generated Specification
api/v3/api.gen.go
Embedded OpenAPI/Swagger spec payload updated to reflect the extension metadata changes from the TypeSpec sources.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • turip
  • borosr
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating extension decorators from InternalExtension to PrivateExtension across multiple API specification files, with one exception in tax operations where the extension was removed entirely.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/api-v3-visibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@tothandras tothandras enabled auto-merge (squash) May 4, 2026 11:37
@tothandras tothandras merged commit 325024d into main May 4, 2026
45 of 47 checks passed
@tothandras tothandras deleted the chore/api-v3-visibility branch May 4, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ignore Ignore this change when generating release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants