fix(filter): fix FilterULID select implementations

[tothandras]

Summary by CodeRabbit

• Bug Fixes

  • Refined filter evaluation logic to properly handle complex filter combinations.

• Tests

  • Added comprehensive test coverage for nested filter conditions and AND/OR operations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0dfbea9b-db82-42fd-bfcb-e378a8cb0399

📥 Commits

Reviewing files that changed from the base of the PR and between ff255ce and 73844b7.

📒 Files selected for processing (2)

• pkg/filter/filter.go
• pkg/filter/filter_test.go

---

📝 Walkthrough

Walkthrough

This PR extends FilterULID to properly handle composed And/Or filters by treating them as SQL predicates. Previously, emptiness checks and SQL generation ignored composition; now they recursively process child filters and correctly identify when filters are truly empty.

Changes

FilterULID And/Or Composition Support

Layer / File(s)	Summary
Empty filter contract pkg/filter/filter.go	IsEmpty() now requires both the embedded FilterString and the And/Or fields to be absent for a filter to be considered empty.
SQL generation for composed filters pkg/filter/filter.go	SelectWhereExpr() and Select() now recursively convert And/Or child filters into q.And() / q.Or() and sql.AndPredicates() / sql.OrPredicates() calls; non-composed filters delegate to embedded FilterString logic.
Test coverage for And/Or recursion and emptiness pkg/filter/filter_test.go	New tests verify that SelectWhereExpr and Select correctly recurse through And/Or wrappers and generate correct SQL for both go-sqlbuilder and Ent paths; IsEmpty() tests confirm behavior for zero-value and partially-filled filters.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: fixing FilterULID's select implementations to properly handle And/Or composition and update IsEmpty logic.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/filter-ulid

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}